Skip to content

OU-1472: move features - #1222

Open
PeterYurkovich wants to merge 1 commit into
idempotent-setupfrom
move-features
Open

OU-1472: move features#1222
PeterYurkovich wants to merge 1 commit into
idempotent-setupfrom
move-features

Conversation

@PeterYurkovich

@PeterYurkovich PeterYurkovich commented Sep 1, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Stack created with GitHub Stacks CLI • Give Feedback 💬

Summary by CodeRabbit

  • New Features

    • Added end-to-end coverage for Incidents, including filtering, chart interactions, silences, permissions, resolution, and high-volume data.
    • Added coverage for Perses dashboard creation, editing, importing, listing, data sources, and LightSpeed chart integration.
    • Added validation for Alerting, Metrics, Observe navigation, and virtualization scenarios across platform perspectives.

  • Tests

    • Expanded regression and performance coverage for monitoring, dashboards, incidents, and COO submenu navigation.
    • Consolidated setup and improved test organization across related scenarios.

@openshift-merge-bot

openshift-merge-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2026
@PeterYurkovich
PeterYurkovich changed the base branch from lint-tags to refactor-variables September 1, 2026 19:24
@PeterYurkovich PeterYurkovich changed the title move features OU-1472: move features Sep 1, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 1, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 1, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@PeterYurkovich: This pull request references OU-1472 which is a valid jira issue.

Details

In response to this:

Stack created with GitHub Stacks CLI • Give Feedback 💬

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PeterYurkovich
PeterYurkovich force-pushed the move-features branch 2 times, most recently from 0f7a323 to 32b8d30 Compare September 2, 2026 12:17
@PeterYurkovich
PeterYurkovich force-pushed the move-features branch 2 times, most recently from a458021 to e3f56dc Compare September 2, 2026 14:49
Base automatically changed from refactor-variables to main September 3, 2026 14:02
@openshift-ci-robot

openshift-ci-robot commented Sep 3, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@PeterYurkovich: This pull request references OU-1472 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Stack created with GitHub Stacks CLI • Give Feedback 💬

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

The saved review history does not include the base for the last reviewed commit. This saved history cannot establish the base for an incremental review. Comment @coderabbitai full review to establish a new review baseline. No full review was started, and the last reviewed checkpoint was preserved.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5a4cc0a2-4cf7-4199-8902-7de20bf60392

📥 Commits

Reviewing files that changed from the base of the PR and between c1ecdf7 and 6a6f54a.

📒 Files selected for processing (1)
  • web/cypress/e2e/legacy-dashboards/legacy_dashboards_regression.cy.ts

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

Walkthrough

The pull request expands Cypress coverage for COO alerting, metrics, incidents, and Perses dashboards. It adds regression, BVT, end-to-end, mock, stress, and performance suites, and consolidates virtualization setup across existing suites.

Changes

Alerting, metrics, and shared COO coverage

Layer / File(s) Summary
Alert and metrics coverage
web/cypress/e2e/alerts/*, web/cypress/e2e/metrics/*, web/cypress/e2e/shared/*, web/cypress/e2e/legacy-dashboards/*		 Adds alerting and metrics coverage for Core platform, Administrator, namespaced, Fleet, and virtualization perspectives. Adds COO submenu checks and updates monitoring-plugin setup.
Virtualization setup consolidation
web/cypress/e2e/alerts/alerts_ivt.cy.ts, web/cypress/e2e/alerts/alerts_virtualization_bvt.cy.ts, web/cypress/e2e/legacy-dashboards/legacy_dashboards_virtualization_regression.cy.ts		 Moves virtualization setup and navigation into existing hooks. Adds signal-correlation visibility checks and removes standalone setup coverage.

Incident coverage

Layer / File(s) Summary
Incident BVT and performance coverage
web/cypress/e2e/incidents/incidents_bvt.cy.ts, web/cypress/e2e/incidents/incidents_e2e.cy.ts, web/cypress/e2e/incidents/incidents_mocking_example.cy.ts, web/cypress/e2e/incidents/performance/*, web/cypress/e2e/incidents/regression/stress_test_ui.cy.ts		 Adds fixture-driven, live, stress, and benchmark coverage for incident charts, filters, tables, selections, and rendering performance.
Incident regression behavior
web/cypress/e2e/incidents/regression/end_and_resolution.cy.ts, filtering.cy.ts, interval.cy.ts, permission_and_silences.cy.ts, ui_interaction.cy.ts, ui_regressions.cy.ts		 Adds regression coverage for alert lifecycle refreshes, filtering, time intervals, permissions, silences, Redux state, tooltips, sorting, visibility, and timestamps.

Perses dashboard coverage

Layer / File(s) Summary
Perses dashboard coverage
web/cypress/e2e/perses-dashboards/*.cy.ts, web/cypress/e2e/perses-dashboards/rbac/*		 Adds dashboard BVT, creation, editing, importing, listing, datasource, RBAC, LightSpeed, and virtualization suites. Updates RBAC import paths for the deeper directory.

Priority: ⬇️ Low

Estimated code review effort: 5 (Critical) | ~90 minutes

Change: Other

Sequence Diagram(s)

sequenceDiagram
  participant Cypress
  participant COO
  participant Incidents
  participant Perses
  Cypress->>COO: configure operators and plugins
  COO->>Incidents: open incident views
  Incidents-->>Cypress: render charts, tables, and filters
  COO->>Perses: open dashboard views
  Perses-->>Cypress: create, edit, import, and persist dashboards
Loading

Merge Risk: ⚪ Minimal · up to 6a6f5

The reviewed changes present no identified merge-blocking behavior or unresolved risk.

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 38 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title relates to the changes, but “move features” is too broad to identify the main work across Cypress test reorganization and idempotent setup. Replace the title with a specific summary, such as “OU-1472: Consolidate COO feature tests with idempotent setup.”
✅ Passed checks (13 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No changed test title contains a run-dependent value. The new describe and it titles use fixed strings. New helper calls pass fixed CustomerPerspectiveName.CorePlatform or `CustomerPerspectiveNa…
Test Structure And Quality ✅ Passed PASS: The custom check applies to Ginkgo test code, but this pull request changes only 41 Cypress .cy.ts files. The authoritative diff contains no Go files and no Ginkgo tests. The changed tests use…
Microshift Test Compatibility ✅ Passed PASS: The authoritative diff changes 41 Cypress .cy.ts files only. It contains no Go files, Ginkgo imports or declarations, MicroShift markers, or added Ginkgo e2e tests. The check is therefore not …
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS. The authoritative PR diff contains only TypeScript Cypress files under web/cypress; it adds or moves Cypress describe, it, before, and beforeEach suites. The diff contains no Ginkgo te…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The review-scoped diff changes only 41 web/cypress/e2e/*.cy.ts files. The changes are file moves, import-path updates, test tags, and Cypress setup/test restructuring. No deployment manifests,…
Ote Binary Stdout Contract ✅ Passed PASS. The reviewed range changes 41 TypeScript Cypress files only. It contains no changed Go/OTE binary sources and no main, init, TestMain, Ginkgo suite runner, klog, fmt output, or direct proc…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The reviewed range changes only TypeScript Cypress suites under web/cypress/e2e; it adds no Ginkgo/Go tests. The added lines contain Cypress UI setup and cy.visit('/'), with no hardcoded IPv…
No-Weak-Crypto ✅ Passed PASS. The reviewed diff primarily moves Cypress files and updates imports/setup. The added lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, cipher, encryption, or custom crypto implementatio…
Container-Privileges ✅ Passed PASS. The authoritative PR diff changes 41 Cypress TypeScript files only, with no container or Kubernetes manifest files. Patch searches found no additions or modifications for privileged: true, `ho…
No-Sensitive-Data-In-Logs ✅ Passed The pull-request diff introduces only five logging calls. Each logs a fixed setup or navigation message. None logs passwords, tokens, API keys, PII, session IDs, hostnames, or customer data. Other dyn…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch move-features

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

openshift-merge-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 835a505 and 1 for PR HEAD d553433 in total

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@PeterYurkovich: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-coo d553433 link false /test e2e-coo

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@PeterYurkovich

PeterYurkovich commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/hold while I add idempotent perses testing to prevent failures

@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 4, 2026
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2026
@openshift-ci

openshift-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2026
@PeterYurkovich
PeterYurkovich removed this pull request from stack #1229 September 9, 2026 18:41
@PeterYurkovich
PeterYurkovich changed the base branch from main to idempotent-setup September 9, 2026 18:42
@PeterYurkovich
PeterYurkovich added this pull request to stack #1250 September 9, 2026 18:45
@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etmurasaki, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etmurasaki, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PeterYurkovich
PeterYurkovich removed this pull request from stack #1250 September 16, 2026 18:37
@PeterYurkovich
PeterYurkovich added this pull request to stack #1287 September 16, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@DavidRajnoha DavidRajnoha Awaiting requested review from DavidRajnoha
@jgbernalp jgbernalp Awaiting requested review from jgbernalp

Assignees

@etmurasaki etmurasaki

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PeterYurkovich @openshift-ci-robot @etmurasaki